fix(megamenu): fix alignment issues in mobile nav #5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annawen1
added
package: react
|
Deploy preview created for package Built with commit: 08f7121a0d82fc6133abdf8eec9e15b5ffd663e9 |
|
Deploy preview created for package Built with commit: 08f7121a0d82fc6133abdf8eec9e15b5ffd663e9 |
|
Deploy preview created for package Built with commit: 08f7121a0d82fc6133abdf8eec9e15b5ffd663e9 |
annawen1
requested review from
raphaelamadeu-zz,
andysherman2121,
ariellalgilmore,
IgnacioBecerra and
jeffchew
annawen1
added
the
Ready to merge
IgnacioBecerra
pushed a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this pull request
Feb 22, 2021
…em#5112) ### Related Ticket(s) React & Web component: Mega Menu - Hamburger menu options are not left aligned and divider lines are missing. carbon-design-system#5079 ### Description BEFORE: <img width="409" alt="Screen Shot 2021-02-05 at 4 18 47 PM" src="https://user-images.githubusercontent.com/54281166/107090920-eb16dc80-67ce-11eb-87d1-05b025535dda.png"> AFTER: <img width="415" alt="Screen Shot 2021-02-05 at 3 56 45 PM" src="https://user-images.githubusercontent.com/54281166/107090929-ee11cd00-67ce-11eb-9bda-3370155643bc.png"> ### Changelog **Changed** - set border-bottom and height for submenus - set text to show ellipsis when overflow in menu item links <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
React & Web component: Mega Menu - Hamburger menu options are not left aligned and divider lines are missing. #5079
Web component: Mega Menu - On landscape mode, IBM logo is cut off and last few mega menu options are not visible. #5080
Description
BEFORE:
AFTER:
Changelog
Changed